Skip to content

Commit

Permalink
Merge pull request #24839 from vipulnsward/fix-bundler-ci
Browse files Browse the repository at this point in the history
Depend on bundler 1.11.2 on travis until bundle update discrepancy is solved on 1.12.x
  • Loading branch information
rafaelfranca committed May 3, 2016
2 parents ab44e36 + a51bdd3 commit 08e86b4
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
6 changes: 4 additions & 2 deletions .travis.yml
Expand Up @@ -16,9 +16,11 @@ addons:
postgresql: "9.4"

bundler_args: --without test --jobs 3 --retry 3

#FIXME: Remove bundler uninstall on Travis when https://github.com/bundler/bundler/issues/4493 is fixed.
before_install:
- gem install bundler
- rvm @global do gem uninstall bundler --all --ignore-dependencies --executables
- rvm @global do gem install bundler -v '1.11.2'
- bundle --version
- "rm ${BUNDLE_GEMFILE}.lock"
- "[ -f /tmp/beanstalkd-1.10/Makefile ] || (curl -L https://github.com/kr/beanstalkd/archive/v1.10.tar.gz | tar xz -C /tmp)"
- "pushd /tmp/beanstalkd-1.10 && make && (./beanstalkd &); popd"
Expand Down
4 changes: 2 additions & 2 deletions activerecord/test/cases/adapters/mysql2/unsigned_type_test.rb
Expand Up @@ -28,10 +28,10 @@ class UnsignedType < ActiveRecord::Base
end

test "minus value is out of range" do
assert_raise(RangeError) do
assert_raise(ActiveModel::RangeError) do
UnsignedType.create(unsigned_integer: -10)
end
assert_raise(RangeError) do
assert_raise(ActiveModel::RangeError) do
UnsignedType.create(unsigned_bigint: -10)
end
assert_raise(ActiveRecord::StatementInvalid) do
Expand Down
Expand Up @@ -18,7 +18,7 @@ class PostgresqlTypeLookupTest < ActiveRecord::PostgreSQLTestCase
bigint_array = @connection.type_map.lookup(1016, -1, "bigint[]")
big_array = [123456789123456789]

assert_raises(RangeError) { int_array.serialize(big_array) }
assert_raises(ActiveModel::RangeError) { int_array.serialize(big_array) }
assert_equal "{123456789123456789}", bigint_array.serialize(big_array)
end

Expand All @@ -27,7 +27,7 @@ class PostgresqlTypeLookupTest < ActiveRecord::PostgreSQLTestCase
bigint_range = @connection.type_map.lookup(3926, -1, "int8range")
big_range = 0..123456789123456789

assert_raises(RangeError) { int_range.serialize(big_range) }
assert_raises(ActiveModel::RangeError) { int_range.serialize(big_range) }
assert_equal "[0,123456789123456789]", bigint_range.serialize(big_range)
end
end
2 changes: 1 addition & 1 deletion activerecord/test/cases/finder_test.rb
Expand Up @@ -174,7 +174,7 @@ def test_exists_passing_active_record_object_is_deprecated
end

def test_exists_fails_when_parameter_has_invalid_type
assert_raises(RangeError) do
assert_raises(ActiveModel::RangeError) do
assert_equal false, Topic.exists?(("9"*53).to_i) # number that's bigger than int
end
assert_equal false, Topic.exists?("foo")
Expand Down

0 comments on commit 08e86b4

Please sign in to comment.