if there is no base name, we cannot determine a primary key

rails · Dec 21, 2010 · 099a210 · 099a210
1 parent 0516806
commit 099a210
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/activerecord/lib/active_record/attribute_methods/primary_key.rb b/activerecord/lib/active_record/attribute_methods/primary_key.rb
@@ -24,11 +24,13 @@ def reset_primary_key #:nodoc:
         end
 
         def get_primary_key(base_name) #:nodoc:
+          return unless base_name
+
           case primary_key_prefix_type
           when :table_name
-            base_name.to_s.foreign_key(false)
+            base_name.foreign_key(false)
           when :table_name_with_underscore
-            base_name.to_s.foreign_key
+            base_name.foreign_key
           else
             'id'
           end

diff --git a/activerecord/test/cases/base_test.rb b/activerecord/test/cases/base_test.rb
@@ -1069,6 +1069,7 @@ def test_define_attr_method_with_value
 
   def test_define_attr_method_with_block
     k = Class.new( ActiveRecord::Base )
+    k.primary_key = "id"
     k.send(:define_attr_method, :primary_key) { "sys_" + original_primary_key }
     assert_equal "sys_id", k.primary_key
   end
@@ -1109,6 +1110,7 @@ def test_set_primary_key_with_value
 
   def test_set_primary_key_with_block
     k = Class.new( ActiveRecord::Base )
+    k.primary_key = 'id'
     k.set_primary_key { "sys_" + original_primary_key }
     assert_equal "sys_id", k.primary_key
   end