Merge pull request #47428 from fatkodima/optimize-schema_dumper-ignore

Optimize `SchemaDumper`s check for ignored tables
rails · Feb 20, 2023 · 09ea3ec · 09ea3ec
1 parent d6c5d38
commit 09ea3ec
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/activerecord/lib/active_record/schema_dumper.rb b/activerecord/lib/active_record/schema_dumper.rb
@@ -292,6 +292,10 @@ def format_index_parts(options)
       end
 
       def remove_prefix_and_suffix(table)
+        # This method appears at the top when profiling active_record test cases run.
+        # Avoid costly calculation when there are no prefix and suffix.
+        return table if @options[:table_name_prefix].blank? && @options[:table_name_suffix].blank?
+
         prefix = Regexp.escape(@options[:table_name_prefix].to_s)
         suffix = Regexp.escape(@options[:table_name_suffix].to_s)
         table.sub(/\A#{prefix}(.+)#{suffix}\z/, "\\1")