avoiding tap saves us time

rails · Aug 11, 2010 · 0f502ab · 0f502ab
1 parent 2b8f249
commit 0f502ab
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb
@@ -49,7 +49,9 @@ def joins(*args)
 
     def where(opts, *rest)
       value = build_where(opts, rest)
-      value ? clone.tap {|r| r.where_values += Array.wrap(value) } : clone
+      copy = clone
+      copy.where_values += Array.wrap(value) if value
+      copy
     end
 
     def having(*args)
@@ -58,7 +60,9 @@ def having(*args)
     end
 
     def limit(value = true)
-      clone.tap {|r| r.limit_value = value }
+      copy = clone
+      copy.limit_value = value
+      copy
     end
 
     def offset(value = true)