do not generate manifest.js in plugins

Since the plugin generator do not generate assets, I think manifest.js also that it unnecessary.
rails · Oct 12, 2015 · 12248b8 · 12248b8
1 parent f50d953
commit 12248b8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/railties/lib/rails/generators/rails/plugin/plugin_generator.rb b/railties/lib/rails/generators/rails/plugin/plugin_generator.rb
@@ -226,7 +226,7 @@ def create_lib_files
       end
 
       def create_assets_manifest_file
-        build(:assets_manifest) unless api?
+        build(:assets_manifest) if !api? && engine?
       end
 
       def create_public_stylesheets_files

diff --git a/railties/test/generators/plugin_generator_test.rb b/railties/test/generators/plugin_generator_test.rb
@@ -60,6 +60,7 @@ def test_generating_without_options
     run_generator
     assert_file "README.rdoc", /Bukkits/
     assert_no_file "config/routes.rb"
+    assert_no_file "app/assets/config/bukkits_manifest.js"
     assert_file "test/test_helper.rb" do |content|
       assert_match(/require.+test\/dummy\/config\/environment/, content)
       assert_match(/ActiveRecord::Migrator\.migrations_paths.+test\/dummy\/db\/migrate/, content)