Use _read_attribute instead of []

It is not only faster, it also doesn't raise an exception if the column was not fetched in the model using select.
rails · Jan 11, 2021 · 15f6b64 · 15f6b64
1 parent 8c60a21
commit 15f6b64
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/activerecord/lib/active_record/associations/belongs_to_association.rb b/activerecord/lib/active_record/associations/belongs_to_association.rb
@@ -111,7 +111,7 @@ def require_counter_update?
         def replace_keys(record, force: false)
           target_key = record ? record._read_attribute(primary_key(record.class)) : nil
 
-          if force || owner[reflection.foreign_key] != target_key
+          if force || owner._read_attribute(reflection.foreign_key) != target_key
             owner[reflection.foreign_key] = target_key
           end
         end

diff --git a/activerecord/lib/active_record/associations/belongs_to_polymorphic_association.rb b/activerecord/lib/active_record/associations/belongs_to_polymorphic_association.rb
@@ -19,7 +19,7 @@ def replace_keys(record, force: false)
 
           target_type = record ? record.class.polymorphic_name : nil
 
-          if force || owner[reflection.foreign_type] != target_type
+          if force || owner._read_attribute(reflection.foreign_type) != target_type
             owner[reflection.foreign_type] = target_type
           end
         end