Merge pull request #17113 from igor04/helpers-highlight

Added processing of `nil` to `highlight` helper method
rails · Sep 30, 2014 · 1f14b9f · 1f14b9f
2 parents 09975bb + 0e50b7b
commit 1f14b9f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/actionview/lib/action_view/helpers/text_helper.rb b/actionview/lib/action_view/helpers/text_helper.rb
@@ -126,7 +126,7 @@ def highlight(text, phrases, options = {})
         text = sanitize(text) if options.fetch(:sanitize, true)
 
         if text.blank? || phrases.blank?
-          text
+          text || ""
         else
           match = Array(phrases).map do |p|
             Regexp === p ? p.to_s : Regexp.escape(p)

diff --git a/actionview/test/template/text_helper_test.rb b/actionview/test/template/text_helper_test.rb
@@ -193,6 +193,10 @@ def test_highlight_pending
     assert_equal '   ', highlight('   ', 'blank text is returned verbatim')
   end
 
+  def test_highlight_should_return_blank_string_for_nil
+    assert_equal '', highlight(nil, 'blank string is returned for nil')
+  end
+
   def test_highlight_should_sanitize_input
     assert_equal(
       "This is a <mark>beautiful</mark> morning",