Add CHANGELOG and fix method doc

rails · May 9, 2024 · 26c2265 · 26c2265
1 parent 9d2a29f
commit 26c2265
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md
@@ -1,3 +1,7 @@
+*   Add option `only_values` on `in_order_of` to allow put some values as priority in the sorting without filter results by this values.
+
+    *Igor Depolli*
+
 *   Fix `index_errors` having incorrect index in association validation errors.
 
     *lulalala*

diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb
@@ -696,13 +696,14 @@ def order!(*args) # :nodoc:
     #   #     WHEN "conversations"."status" = 0 THEN 3
     #   #   END ASC
     #
-    # +only_values+ can be set to +false+ to include all scope instead of only the ones specified in +values+.
+    # +only_values+ can be set to +false+ to include all results instead of only the ones specified in +values+.
     #
     #   Conversation.in_order_of(:status, [:archived, :active], only_values: false)
     #   # SELECT "conversations".* FROM "conversations"
     #   #   ORDER BY CASE
     #   #     WHEN "conversations"."status" = 1 THEN 1
     #   #     WHEN "conversations"."status" = 0 THEN 2
+    #   #     ELSE 3
     #   #   END ASC
     #
     def in_order_of(column, values, only_values: true)