Skip to content

Commit

Permalink
Merge pull request #22222 from y-yagi/fix_application_controller_requ…
Browse files Browse the repository at this point in the history
…ire_dependency_path_in_api

fix application_controller require_dependency path generated by api scaffold generator
  • Loading branch information
chancancode committed Nov 8, 2015
2 parents 54c87a1 + 595fa6e commit 280654e
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
@@ -1,5 +1,5 @@
<% if namespaced? -%>
require_dependency "<%= namespaced_file_path %>/application_controller"
require_dependency "<%= namespaced_path %>/application_controller"
<% end -%>
<% module_namespacing do -%>
Expand Down
24 changes: 24 additions & 0 deletions railties/test/generators/namespaced_generators_test.rb
Expand Up @@ -396,4 +396,28 @@ def test_scaffold_with_nested_namespace_on_revoke
# Stylesheets (should not be removed)
assert_file "app/assets/stylesheets/scaffold.css"
end

def test_api_scaffold_with_namespace_on_invoke
run_generator [ "admin/role", "name:string", "description:string", "--api" ]

# Model
assert_file "app/models/test_app/admin.rb", /module TestApp\n module Admin/
assert_file "app/models/test_app/admin/role.rb", /module TestApp\n class Admin::Role < ActiveRecord::Base/
assert_file "test/models/test_app/admin/role_test.rb", /module TestApp\n class Admin::RoleTest < ActiveSupport::TestCase/
assert_file "test/fixtures/test_app/admin/roles.yml"
assert_migration "db/migrate/create_test_app_admin_roles.rb"

# Route
assert_file "config/routes.rb" do |route|
assert_match(/^ namespace :admin do\n resources :roles\n end$/, route)
end

# Controller
assert_file "app/controllers/test_app/admin/roles_controller.rb" do |content|
assert_match(/module TestApp\n class Admin::RolesController < ApplicationController/, content)
assert_match(%r(require_dependency "test_app/application_controller"), content)
end
assert_file "test/controllers/test_app/admin/roles_controller_test.rb",
/module TestApp\n class Admin::RolesControllerTest < ActionController::TestCase/
end
end

0 comments on commit 280654e

Please sign in to comment.