Skip to content

Commit

Permalink
Some documentation fixes [ci skip]
Browse files Browse the repository at this point in the history
  • Loading branch information
robin850 committed Aug 29, 2014
1 parent 7447e0b commit 38d6c72
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions activejob/lib/active_job/callbacks.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
module ActiveJob
# = Active Job Callbacks
#
# Active Job provides hooks during the lifecycle of a job. Callbacks allow you to trigger
# logic during the lifecycle of a job. Available callbacks:
# Active Job provides hooks during the lifecycle of a job. Callbacks allow you
# to trigger logic during the lifecycle of a job. Available callbacks are:
#
# * <tt>before_enqueue</tt>
# * <tt>around_enqueue</tt>
Expand Down
2 changes: 1 addition & 1 deletion activejob/lib/active_job/gem_version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module ActiveJob
# Returns the version of the currently loaded Active Job as a <tt>Gem::Version</tt>
# Returns the version of the currently loaded ActiveJob as a <tt>Gem::Version</tt>

This comment has been minimized.

Copy link
@chancancode

chancancode Aug 30, 2014

Member

This comment has been minimized.

Copy link
@chancancode

chancancode Aug 30, 2014

Member

see also a57f7b5

This comment has been minimized.

Copy link
@robin850

robin850 Aug 30, 2014

Author Member

Actually I don't really know whether we are speaking about the constant or the library. Anyway, when we load one, the other will be as well. This change was just to be consistent with the other components:

Should we change them all to refer to the library and not the constant or keep it as is ? /cc @fxn

This comment has been minimized.

Copy link
@chancancode

chancancode Aug 30, 2014

Member

Seems like we should change all of them 😄 the constant doesn't have a version, the gem (activejob) or the library ("Active Job") does.

Well the constant/module do have a VERSION, but pretty sure we are not referring to that here ;)

This comment has been minimized.

Copy link
@fxn

fxn Aug 30, 2014

Member

Yes, in general applications load libraries. You load Nokogiri, a certain version. By loading the gem you get the Nokogiri constant (and a bunch of other stuff), but that is not what you have in mind.

This comment has been minimized.

Copy link
@robin850

robin850 Aug 30, 2014

Author Member

Okay, thanks guys ; this has been fixed in 84c0f73. :-)

This comment has been minimized.

Copy link
@fxn

fxn Aug 30, 2014

Member

❤️

def self.gem_version
Gem::Version.new VERSION::STRING
end
Expand Down
14 changes: 7 additions & 7 deletions guides/source/4_2_release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -289,15 +289,15 @@ Please refer to the [Changelog][action-pack] for detailed changes.
* The way `assert_select` works has changed; specifically a different library
is used to interpret css selectors, build the transient DOM that the
selectors are applied against, and to extract the data from that DOM. These
changes should only affect edge cases. Examples:
selectors are applied against, and to extract the data from that DOM. These
changes should only affect edge cases. Examples:
* Values in attribute selectors may need to be quoted if they contain
non-alphanumeric characters
* DOMs built from HTML source containing invalid HTML containing improperly
nested elements may differ
non-alphanumeric characters.
* DOMs built from HTML source containing invalid HTML with improperly
nested elements may differ.
* If the data selected contains entities, the value selected for comparison
used to be raw (example: `AT&amp;T`), and now is evaluated
(example: `AT&T`)
used to be raw (e.g. `AT&amp;T`), and now is evaluated
(e.g. `AT&T`).
Action View
Expand Down

0 comments on commit 38d6c72

Please sign in to comment.