Merge pull request #2011 from amatsuda/with_index

replaced some "i += 1" sort of codes with Enumerable#with_index
rails · Jul 8, 2011 · 3a1ec9b · 3a1ec9b
2 parents ad912c0 + dab0de4
commit 3a1ec9b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/activerecord/lib/active_record/relation.rb b/activerecord/lib/active_record/relation.rb
@@ -250,8 +250,7 @@ def update_all(updates, conditions = nil, options = {})
     #   Person.update(people.keys, people.values)
     def update(id, attributes)
       if id.is_a?(Array)
-        idx = -1
+        id.each.with_index.map {|one_id, idx| update(one_id, attributes[idx])}
-        id.collect { |one_id| idx += 1; update(one_id, attributes[idx]) }
       else
         object = find(id)
         object.update_attributes(attributes)

diff --git a/activerecord/test/cases/fixtures_test.rb b/activerecord/test/cases/fixtures_test.rb
@@ -178,11 +178,9 @@ def test_omap_fixtures
     assert_nothing_raised do
       fixtures = ActiveRecord::Fixtures.new(Account.connection, 'categories', 'Category', FIXTURES_ROOT + "/categories_ordered")
 
-      i = 0
+      fixtures.each.with_index do |(name, fixture), i|
-      fixtures.each do |name, fixture|
         assert_equal "fixture_no_#{i}", name
         assert_equal "Category #{i}", fixture['name']
-        i += 1
       end
     end
   end