Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Changed the implementation of Enumerable#group_by to use a double arr…

…ay approach instead of a hash such that the insert order is honored [DHH/Marcel]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8516 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
  • Loading branch information...
commit 438b108c6bea3d9781c0ecd5e53d362b29fe7f6b 1 parent 07de761
@dhh dhh authored
View
2  activesupport/CHANGELOG
@@ -1,5 +1,7 @@
*SVN*
+* Changed the implementation of Enumerable#group_by to use a double array approach instead of a hash such that the insert order is honored [DHH/Marcel]
+
* remove multiple enumerations from ActiveSupport::JSON#convert_json_to_yaml when dealing with date/time values. [rick]
* Hash#symbolize_keys skips keys that can't be symbolized. #10500 [Brad Greenlee]
View
9 activesupport/lib/active_support/core_ext/enumerable.rb
@@ -15,8 +15,13 @@ module Enumerable
# "2006-02-24 -> Transcript, Transcript"
# "2006-02-23 -> Transcript"
def group_by
- inject({}) do |groups, element|
- (groups[yield(element)] ||= []) << element
+ inject([]) do |groups, element|
+ value = yield(element)
+ if (last_group = groups.last) && last_group.first == value
+ last_group.last << element
+ else
+ groups << [value, [element]]
+ end
groups
end
end if RUBY_VERSION < '1.9'
Please sign in to comment.
Something went wrong with that request. Please try again.