Skip to content
Permalink
Browse files
Remove deprecated `ActiveRecord::ConnectionAdapters::SQLite3Adapter#v…
…alid_alter_table_type?`
  • Loading branch information
rafaelfranca committed Jan 17, 2019
1 parent 91ddb30 commit 45b4d5f81f0c0ca72c18d0dea4a3a7b2ecc589bf
@@ -1,3 +1,7 @@
* Remove deprecated `ActiveRecord::ConnectionAdapters::SQLite3Adapter#valid_alter_table_type?`.

*Rafael Mendonça França*

* Do not allow passing the column name to `sum` when a block is passed.

*Rafael Mendonça França*
@@ -307,11 +307,6 @@ def rename_table(table_name, new_name)
rename_table_indexes(table_name, new_name)
end

def valid_alter_table_type?(type, options = {})
!invalid_alter_table_type?(type, options)
end
deprecate :valid_alter_table_type?

def add_column(table_name, column_name, type, options = {}) #:nodoc:
if invalid_alter_table_type?(type, options)
alter_table(table_name) do |definition|
@@ -536,10 +536,6 @@ def test_statement_closed
end
end

def test_deprecate_valid_alter_table_type
assert_deprecated { @conn.valid_alter_table_type?(:string) }
end

def test_db_is_not_readonly_when_readonly_option_is_false
conn = Base.sqlite3_connection database: ":memory:",
adapter: "sqlite3",

0 comments on commit 45b4d5f

Please sign in to comment.