Skip to content

Commit 45b4d5f

Browse files
committed
Remove deprecated ActiveRecord::ConnectionAdapters::SQLite3Adapter#valid_alter_table_type?
1 parent 91ddb30 commit 45b4d5f

3 files changed

Lines changed: 4 additions & 9 deletions

File tree

‎activerecord/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
* Remove deprecated `ActiveRecord::ConnectionAdapters::SQLite3Adapter#valid_alter_table_type?`.
2+
3+
*Rafael Mendonça França*
4+
15
* Do not allow passing the column name to `sum` when a block is passed.
26

37
*Rafael Mendonça França*

‎activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -307,11 +307,6 @@ def rename_table(table_name, new_name)
307307
rename_table_indexes(table_name, new_name)
308308
end
309309

310-
def valid_alter_table_type?(type, options = {})
311-
!invalid_alter_table_type?(type, options)
312-
end
313-
deprecate :valid_alter_table_type?
314-
315310
def add_column(table_name, column_name, type, options = {}) #:nodoc:
316311
if invalid_alter_table_type?(type, options)
317312
alter_table(table_name) do |definition|

‎activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -536,10 +536,6 @@ def test_statement_closed
536536
end
537537
end
538538

539-
def test_deprecate_valid_alter_table_type
540-
assert_deprecated { @conn.valid_alter_table_type?(:string) }
541-
end
542-
543539
def test_db_is_not_readonly_when_readonly_option_is_false
544540
conn = Base.sqlite3_connection database: ":memory:",
545541
adapter: "sqlite3",

0 commit comments

Comments
 (0)