Skip to content

Commit

Permalink
Add rindex to ActiveSupport::Multibyte::Chars.
Browse files Browse the repository at this point in the history
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  • Loading branch information
eostrom authored and jeremy committed Aug 10, 2009
1 parent e06a0b0 commit 4dda9b6
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
13 changes: 13 additions & 0 deletions activesupport/lib/active_support/multibyte/chars.rb
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,19 @@ def index(needle, offset=0)
index ? (self.class.u_unpack(@wrapped_string.slice(0...index)).size) : nil
end

# Returns the position _needle_ in the string, counting in
# codepoints, searching backward from _offset_ or the end of the
# string. Returns +nil+ if _needle_ isn't found.
#
# Example:
# 'Café périferôl'.mb_chars.rindex('é') #=> 5
# 'Café périferôl'.mb_chars.rindex(/\w/u) #=> 13
def rindex(needle, offset=nil)
offset ||= length
index = @wrapped_string.rindex(needle, offset)
index ? (self.class.u_unpack(@wrapped_string.slice(0...index)).size) : nil
end

# Like <tt>String#[]=</tt>, except instead of byte offsets you specify character offsets.
#
# Example:
Expand Down
7 changes: 7 additions & 0 deletions activesupport/test/multibyte_chars_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,13 @@ def test_index_should_return_character_offset
assert_equal 3, @chars.index('わ')
end

def test_rindex_should_return_character_offset
assert_nil @chars.rindex('u')
assert_equal 1, @chars.rindex('に')
assert_equal 6, 'Café périferôl'.mb_chars.rindex('é')
assert_equal 12, 'Café périferôl'.mb_chars.rindex(/\w/u)
end

def test_indexed_insert_should_take_character_offsets
@chars[2] = 'a'
assert_equal 'こにaわ', @chars
Expand Down

0 comments on commit 4dda9b6

Please sign in to comment.