Avoid new string instance creation in InsertAll#execute

rails · Apr 22, 2019 · 5454cc4 · 5454cc4
1 parent 70d6416
commit 5454cc4
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/activerecord/lib/active_record/insert_all.rb b/activerecord/lib/active_record/insert_all.rb
@@ -21,9 +21,9 @@ def initialize(model, inserts, on_duplicate:, returning: nil, unique_by: nil)
     end
 
     def execute
-      message = "#{model} "
-      message += "Bulk " if inserts.many?
-      message += (on_duplicate == :update ? "Upsert" : "Insert")
+      message = +"#{model} "
+      message << "Bulk " if inserts.many?
+      message << (on_duplicate == :update ? "Upsert" : "Insert")
       connection.exec_query to_sql, message
     end