Skip to content

Commit

Permalink
Merge pull request #7396 from tomykaira/cleanup_test
Browse files Browse the repository at this point in the history
Access @rs only through attr_accessor
  • Loading branch information
rafaelfranca committed Aug 20, 2012
2 parents 937a825 + 503c1c0 commit 6904af1
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions actionpack/test/controller/routing_test.rb
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def test_optional_star_paths_are_greedy_but_not_too_much
end end


def test_regexp_precidence def test_regexp_precidence
@rs.draw do rs.draw do
get '/whois/:domain', :constraints => { get '/whois/:domain', :constraints => {
:domain => /\w+\.[\w\.]+/ }, :domain => /\w+\.[\w\.]+/ },
:to => lambda { |env| [200, {}, %w{regexp}] } :to => lambda { |env| [200, {}, %w{regexp}] }
Expand All @@ -216,7 +216,7 @@ def matches? request
end end
} }


@rs.draw do rs.draw do
get '/', :constraints => subdomain.new, get '/', :constraints => subdomain.new,
:to => lambda { |env| [200, {}, %w{default}] } :to => lambda { |env| [200, {}, %w{default}] }
get '/', :constraints => { :subdomain => 'clients' }, get '/', :constraints => { :subdomain => 'clients' },
Expand All @@ -228,7 +228,7 @@ def matches? request
end end


def test_lambda_constraints def test_lambda_constraints
@rs.draw do rs.draw do
get '/', :constraints => lambda { |req| get '/', :constraints => lambda { |req|
req.subdomain.present? and req.subdomain != "clients" }, req.subdomain.present? and req.subdomain != "clients" },
:to => lambda { |env| [200, {}, %w{default}] } :to => lambda { |env| [200, {}, %w{default}] }
Expand Down Expand Up @@ -266,22 +266,22 @@ def test_non_greedy_glob_regexp


def test_draw_with_block_arity_one_raises def test_draw_with_block_arity_one_raises
assert_raise(RuntimeError) do assert_raise(RuntimeError) do
@rs.draw { |map| map.match '/:controller(/:action(/:id))' } rs.draw { |map| map.match '/:controller(/:action(/:id))' }
end end
end end


def test_specific_controller_action_failure def test_specific_controller_action_failure
@rs.draw do rs.draw do
mount lambda {} => "/foo" mount lambda {} => "/foo"
end end


assert_raises(ActionController::RoutingError) do assert_raises(ActionController::RoutingError) do
url_for(@rs, :controller => "omg", :action => "lol") url_for(rs, :controller => "omg", :action => "lol")
end end
end end


def test_default_setup def test_default_setup
@rs.draw { get '/:controller(/:action(/:id))' } rs.draw { get '/:controller(/:action(/:id))' }
assert_equal({:controller => "content", :action => 'index'}, rs.recognize_path("/content")) assert_equal({:controller => "content", :action => 'index'}, rs.recognize_path("/content"))
assert_equal({:controller => "content", :action => 'list'}, rs.recognize_path("/content/list")) assert_equal({:controller => "content", :action => 'list'}, rs.recognize_path("/content/list"))
assert_equal({:controller => "content", :action => 'show', :id => '10'}, rs.recognize_path("/content/show/10")) assert_equal({:controller => "content", :action => 'show', :id => '10'}, rs.recognize_path("/content/show/10"))
Expand All @@ -298,8 +298,8 @@ def test_default_setup
end end


def test_ignores_leading_slash def test_ignores_leading_slash
@rs.clear! rs.clear!
@rs.draw { get '/:controller(/:action(/:id))'} rs.draw { get '/:controller(/:action(/:id))'}
test_default_setup test_default_setup
end end


Expand Down Expand Up @@ -470,7 +470,7 @@ def test_named_route_with_regexps
end end


def test_changing_controller def test_changing_controller
@rs.draw { get ':controller/:action/:id' } rs.draw { get ':controller/:action/:id' }


assert_equal '/admin/stuff/show/10', assert_equal '/admin/stuff/show/10',
url_for(rs, {:controller => 'stuff', :action => 'show', :id => 10}, url_for(rs, {:controller => 'stuff', :action => 'show', :id => 10},
Expand Down Expand Up @@ -583,7 +583,7 @@ def test_route_with_text_default
end end


def test_action_expiry def test_action_expiry
@rs.draw { get ':controller(/:action(/:id))' } rs.draw { get ':controller(/:action(/:id))' }
assert_equal '/content', url_for(rs, { :controller => 'content' }, { :controller => 'content', :action => 'show' }) assert_equal '/content', url_for(rs, { :controller => 'content' }, { :controller => 'content', :action => 'show' })
end end


Expand Down

0 comments on commit 6904af1

Please sign in to comment.