-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
macruby: no format_datetime or msg2str
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d91e7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I wonder if the issue isn't that we need to update the stdlib so that our Logger doesn't have :formatter= defined. Do you know by any chance when that method was removed in 1.9.x?
6d91e7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So scratch that, I've done some more investigation. It seems our method_defined? impl. falsely returns `false', thus it gets to the part where it tries to alias the method which doesn't/shouldn't exist. We've added a test_vm test for it, I'll have a look into it later on:
http://github.com/masterkain/macruby/commit/fc682c00466f26e7bb971832c3d5e2d948f91c8b
Thanks for using beta software! ;-)
6d91e7d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, method_defined? has been fixed, so you could probably revert this: http://github.com/masterkain/macruby/commit/b7806fed28b327b95cb3b42f293477937a693ff4