Remove deprecated ActiveModel::Errors#values

rails · Nov 17, 2021 · 6fed53b · 6fed53b
1 parent 362e17e
commit 6fed53b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 29 deletions.
diff --git a/activemodel/CHANGELOG.md b/activemodel/CHANGELOG.md
@@ -1,3 +1,7 @@
+*   Remove deprecated `ActiveModel::Errors#values`.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated `ActiveModel::Errors#slice!`.
 
     *Rafael Mendonça França*

diff --git a/activemodel/lib/active_model/errors.rb b/activemodel/lib/active_model/errors.rb
@@ -200,15 +200,6 @@ def each(&block)
       @errors.each(&block)
     end
 
-    # Returns all message values.
-    #
-    #   person.errors.messages # => {:name=>["cannot be nil", "must be specified"]}
-    #   person.errors.values   # => [["cannot be nil", "must be specified"]]
-    def values
-      deprecation_removal_warning(:values, "errors.map { |error| error.message }")
-      @errors.map(&:message).freeze
-    end
-
     # Returns all message keys.
     #
     #   person.errors.messages # => {:name=>["cannot be nil", "must be specified"]}

diff --git a/activemodel/test/cases/errors_test.rb b/activemodel/test/cases/errors_test.rb
@@ -127,16 +127,6 @@ def test_no_key
     assert_equal ["omg"], errors["name"]
   end
 
-  test "values returns an array of messages" do
-    errors = ActiveModel::Errors.new(Person.new)
-    assert_deprecated { errors.messages[:foo] = "omg" }
-    assert_deprecated { errors.messages[:baz] = "zomg" }
-
-    assert_deprecated do
-      assert_equal ["omg", "zomg"], errors.values
-    end
-  end
-
   test "[]= overrides values" do
     errors = ActiveModel::Errors.new(self)
     assert_deprecated { errors.messages[:foo] = "omg" }
@@ -145,16 +135,6 @@ def test_no_key
     assert_equal ["zomg"], errors[:foo]
   end
 
-  test "values returns an empty array after try to get a message only" do
-    errors = ActiveModel::Errors.new(Person.new)
-    errors.messages[:foo]
-    errors.messages[:baz]
-
-    assert_deprecated do
-      assert_equal [], errors.values
-    end
-  end
-
   test "keys returns the error keys" do
     errors = ActiveModel::Errors.new(Person.new)
     assert_deprecated { errors.messages[:foo] << "omg" }

diff --git a/guides/source/7_0_release_notes.md b/guides/source/7_0_release_notes.md
@@ -128,6 +128,8 @@ Please refer to the [Changelog][active-model] for detailed changes.
 
 *   Remove deprecated `ActiveModel::Errors#slice!`.
 
+*   Remove deprecated `ActiveModel::Errors#values`.
+
 ### Deprecations
 
 ### Notable changes