Support limit(n) and offset(n) nodes in dot output

rails · May 1, 2020 · 7669dc2 · 7669dc2
1 parent ff1b97a
commit 7669dc2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/activerecord/lib/arel/visitors/dot.rb b/activerecord/lib/arel/visitors/dot.rb
@@ -222,7 +222,7 @@ def visit_Arel_Nodes_BindParam(o)
           edge("value") { visit o.value }
         end
 
-        def visit_ActiveRecord_Relation_QueryAttribute(o)
+        def visit_ActiveModel_Attribute(o)
           edge("value_before_type_cast") { visit o.value_before_type_cast }
         end
 

diff --git a/activerecord/test/cases/arel/visitors/dot_test.rb b/activerecord/test/cases/arel/visitors/dot_test.rb
@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "../helper"
+require "active_model/attribute"
 
 module Arel
   module Visitors
@@ -78,6 +79,12 @@ def test_Arel_Nodes_BindParam
         collector = Collectors::PlainString.new
         assert_match '[label="<f0>Arel::Nodes::BindParam"]', @visitor.accept(node, collector).value
       end
+
+      def test_ActiveModel_Attribute
+        node = ActiveModel::Attribute.with_cast_value("LIMIT", 1, nil)
+        collector = Collectors::PlainString.new
+        assert_match '[label="<f0>ActiveModel::Attribute::WithCastValue"]', @visitor.accept(node, collector).value
+      end
     end
   end
 end