Merge pull request #44404 from kmcphillips/mysql-quote-rational

Handle quoting of Rational numbers for MySQL

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Fix quoting of `ActiveSupport::Duration` and `Rational` numbers in the MySQL adapter.
+
+    *Kevin McPhillips*
+
 *   Allow column name with COLLATE (e.g., title COLLATE "C") as safe SQL string
 
     *Shugo Maeda*

activerecord/lib/active_record/connection_adapters/mysql/quoting.rb

@@ -8,6 +8,8 @@ module MySQL
       module Quoting # :nodoc:
         def quote_bound_value(value)
           case value
+          when Rational
+            quote(value.to_f.to_s)
           when Numeric, ActiveSupport::Duration
             quote(value.to_s)
           when BigDecimal

activerecord/test/cases/adapters/mysql2/bind_parameter_test.rb

@@ -73,6 +73,11 @@ def test_where_with_decimal_for_string_column_using_bind_parameters
           assert_equal 0, count
         end
 
+        def test_where_with_rational_for_string_column_using_bind_parameters
+          count = Post.where("title = ?", Rational(0)).count
+          assert_equal 0, count
+        end
+
         def test_where_with_duration_for_string_column_using_bind_parameters
           count = Post.where("title = ?", 0.seconds).count
           assert_equal 0, count

activerecord/test/cases/adapters/mysql2/quoting_test.rb

@@ -16,6 +16,10 @@ def test_quote_bound_big_decimal
     assert_equal "'4.2'", @conn.quote_bound_value(BigDecimal("4.2"))
   end
 
+  def test_quote_bound_rational
+    assert_equal "'0.75'", @conn.quote_bound_value(Rational(3, 4))
+  end
+
   def test_quote_bound_duration
     assert_equal "'42'", @conn.quote_bound_value(42.seconds)
   end

activerecord/test/cases/adapters/postgresql/bind_parameter_test.rb

@@ -38,6 +38,12 @@ def test_where_with_decimal_for_string_column_using_bind_parameters
           end
         end
 
+        def test_where_with_rational_for_string_column_using_bind_parameters
+          assert_raises ActiveRecord::StatementInvalid do
+            Post.where("title = ?", Rational(0)).count
+          end
+        end
+
         def test_where_with_duration_for_string_column_using_bind_parameters
           assert_raises ActiveRecord::StatementInvalid do
             Post.where("title = ?", 0.seconds).count

activerecord/test/cases/adapters/sqlite3/bind_parameter_test.rb

@@ -34,6 +34,11 @@ def test_where_with_decimal_for_string_column_using_bind_parameters
           assert_equal 0, count
         end
 
+        def test_where_with_rational_for_string_column_using_bind_parameters
+          count = Post.where("title = ?", Rational(0)).count
+          assert_equal 0, count
+        end
+
         def test_where_with_duration_for_string_column_using_bind_parameters
           count = Post.where("title = ?", 0.seconds).count
           assert_equal 0, count

activerecord/test/cases/relation/where_test.rb

@@ -336,6 +336,11 @@ def test_where_with_decimal_for_string_column
       assert_equal 0, count
     end
 
+    def test_where_with_rational_for_string_column
+      count = Post.where(title: Rational(0)).count
+      assert_equal 0, count
+    end
+
     def test_where_with_duration_for_string_column
       count = Post.where(title: 0.seconds).count
       assert_equal 0, count