Skip to content

Commit

Permalink
bump AS deprecation_horizon to 4.1
Browse files Browse the repository at this point in the history
  • Loading branch information
Francesco Rodríguez committed Jun 17, 2012
1 parent 8690d5a commit 8247336
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions activesupport/lib/active_support/deprecation.rb
Expand Up @@ -10,10 +10,10 @@ class << self
# The version the deprecated behavior will be removed, by default.
attr_accessor :deprecation_horizon
end
self.deprecation_horizon = '3.2'
self.deprecation_horizon = '4.1'

This comment has been minimized.

Copy link
@spastorino

spastorino Jun 18, 2012

Contributor

Shouldn't this be also changed in 3-2-stable, from 3.2 to 4.0?

This comment has been minimized.

Copy link
@frodsan

frodsan Jun 18, 2012

Contributor

I have the feeling that this is not being used. I will research.

This comment has been minimized.

Copy link
@frodsan

frodsan Jun 18, 2012

Contributor

So far, i just have seen that people use ActiveSupport::Deprecation.warn method to raise deprecation warnings.

The only place where i found Module#deprecate method is in activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb:

def clear_stale_cached_connections! # :nodoc:
  reap
end
deprecate :clear_stale_cached_connections! => "Please use #reap instead"

Probably, we can use ActiveSupport::Deprecation.warn instead and remove
some AS::Deprecation unused methods?

This comment has been minimized.

Copy link
@frodsan

frodsan Jun 18, 2012

Contributor

This comment has been minimized.

Copy link
@rafaelfranca

rafaelfranca Jun 18, 2012

Member

Yes, nobody is using the deprecate method, so the deprecation_horizon doesn't make difference. I think we should start to use deprecate where we can.

This comment has been minimized.

Copy link
@frodsan

frodsan Jun 26, 2013

Contributor

Can we reach an agreement about how to deprecate things? If everyone is using #warn, maybe we can remove the #deprecate method and stop maintaining code that is not being used. Thoughts?


# By default, warnings are not silenced and debugging is off.
self.silenced = false
self.debug = false
end
end
end

0 comments on commit 8247336

Please sign in to comment.