Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Added test for verifying that we treat line number indications from…
… irb as user/lib code - Cleaned up backtrace cleaner test code and removed instaces variables
- Loading branch information
1 parent
1eb3582
commit 8e1714b
Showing
1 changed file
with
16 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,32 @@ | ||
require 'abstract_unit' | ||
require 'rails/backtrace_cleaner' | ||
|
||
class BacktraceCleanerVendorGemTest < ActiveSupport::TestCase | ||
class BacktraceCleanerTest < ActiveSupport::TestCase | ||
def setup | ||
@cleaner = Rails::BacktraceCleaner.new | ||
end | ||
|
||
test "should format installed gems correctly" do | ||
@backtrace = [ "#{Gem.path[0]}/gems/nosuchgem-1.2.3/lib/foo.rb" ] | ||
@result = @cleaner.clean(@backtrace, :all) | ||
assert_equal "nosuchgem (1.2.3) lib/foo.rb", @result[0] | ||
backtrace = [ "#{Gem.path[0]}/gems/nosuchgem-1.2.3/lib/foo.rb" ] | ||
result = @cleaner.clean(backtrace, :all) | ||
assert_equal "nosuchgem (1.2.3) lib/foo.rb", result[0] | ||
end | ||
|
||
test "should format installed gems not in Gem.default_dir correctly" do | ||
@target_dir = Gem.path.detect { |p| p != Gem.default_dir } | ||
target_dir = Gem.path.detect { |p| p != Gem.default_dir } | ||
# skip this test if default_dir is the only directory on Gem.path | ||
if @target_dir | ||
@backtrace = [ "#{@target_dir}/gems/nosuchgem-1.2.3/lib/foo.rb" ] | ||
@result = @cleaner.clean(@backtrace, :all) | ||
assert_equal "nosuchgem (1.2.3) lib/foo.rb", @result[0] | ||
backtrace = [ "#{target_dir}/gems/nosuchgem-1.2.3/lib/foo.rb" ] | ||
result = @cleaner.clean(backtrace, :all) | ||
assert_equal "nosuchgem (1.2.3) lib/foo.rb", result[0] | ||
end | ||
end | ||
|
||
test "should consider traces from irb lines as User code" do | ||
backtrace = [ "from (irb):1", | ||
"from /Path/to/rails/railties/lib/rails/commands/console.rb:77:in `start'", | ||
"from bin/rails:4:in `<main>'" ] | ||
result = @cleaner.clean(backtrace, :all) | ||
assert_equal "from (irb):1", result[0] | ||
end | ||
end |