Merge pull request #21952 from headius/only_one_module_for_deprecation

Only prepend a single module when defining deprecation wrappers.
rails · Oct 13, 2015 · 8e7a3b0 · 8e7a3b0
2 parents de732e0 + d29f7fb
commit 8e7a3b0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/activesupport/lib/active_support/deprecation/method_wrappers.rb b/activesupport/lib/active_support/deprecation/method_wrappers.rb
@@ -30,16 +30,16 @@ def deprecate_methods(target_module, *method_names)
         deprecator = options.delete(:deprecator) || ActiveSupport::Deprecation.instance
         method_names += options.keys
 
-        method_names.each do |method_name|
-          mod = Module.new do
+        mod = Module.new do
+          method_names.each do |method_name|
             define_method(method_name) do |*args, &block|
               deprecator.deprecation_warning(method_name, options[method_name])
               super(*args, &block)
             end
           end
-
-          target_module.prepend(mod)
         end
+
+        target_module.prepend(mod)
       end
     end
   end