Fix cases where the wrong name is passed to Formatter#generate

These are currently working "by accident" because `match_route` does not check that the name is valid.
rails · Nov 23, 2014 · 938d130 · 938d130
1 parent b7b9e92
commit 938d130
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/actionpack/test/controller/routing_test.rb b/actionpack/test/controller/routing_test.rb
@@ -1386,7 +1386,7 @@ def test_named_routes_are_never_relative_to_modules
     url = controller.url_for({ :controller => "connection", :only_path => true })
     assert_equal "/connection/connection", url
 
-    url = controller.url_for({ :use_route => :family_connection,
+    url = controller.url_for({ :use_route => "family_connection",
                                :controller => "connection", :only_path => true })
     assert_equal "/connection", url
   end

diff --git a/actionpack/test/journey/router_test.rb b/actionpack/test/journey/router_test.rb
@@ -415,7 +415,7 @@ def test_generate_uses_recall_if_needed
 
       def test_generate_with_name
         path  = Path::Pattern.from_string '/:controller(/:action)'
-        @router.routes.add_route @app, path, {}, {}, {}
+        @router.routes.add_route @app, path, {}, {}, "tasks"
 
         path, params = @formatter.generate(
           "tasks",