Fix warnings for attribute methods with kwargs

rails · Jan 20, 2020 · a070260 · a070260
1 parent 72cd217
commit a070260
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/activemodel/lib/active_model/attribute_methods.rb b/activemodel/lib/active_model/attribute_methods.rb
@@ -432,6 +432,7 @@ def method_missing(method, *args, &block)
         match ? attribute_missing(match, *args, &block) : super
       end
     end
+    ruby2_keywords(:method_missing) if respond_to?(:ruby2_keywords, true)
 
     # +attribute_missing+ is like +method_missing+, but for attributes. When
     # +method_missing+ is called we check to see if there is a matching

diff --git a/activemodel/test/cases/attribute_methods_test.rb b/activemodel/test/cases/attribute_methods_test.rb
@@ -26,7 +26,7 @@ class ModelWithAttributes2
 
   attr_accessor :attributes
 
-  attribute_method_suffix "_test"
+  attribute_method_suffix "_test", "_kw"
 
 private
   def attribute(name)
@@ -37,6 +37,10 @@ def attribute_test(name, attrs = {})
     attrs[name] = attribute(name)
   end
 
+  def attribute_kw(name, kw: 1)
+    attribute(name)
+  end
+
   def private_method
     "<3 <3"
   end
@@ -217,6 +221,7 @@ def foo
     attrs = {}
 
     assert_equal "bar", m.foo
+    assert_equal "bar", m.foo_kw(kw: 2)
     assert_equal "bar", m.foo_test(attrs)
     assert_equal "bar", attrs["foo"]
   end
@@ -229,6 +234,7 @@ def foo
     attrs = {}
 
     assert_equal "bar", m.foo
+    assert_equal "bar", m.foo_kw(kw: 2)
     assert_equal "bar", m.foo_test(attrs)
     assert_equal "bar", attrs["foo"]
   ensure