Invert conditional

This avoid a method call and also is easier to read.
rails · Nov 15, 2021 · a134eeb · a134eeb
1 parent 83ce6e3
commit a134eeb
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/activesupport/lib/active_support/core_ext/object/with_options.rb b/activesupport/lib/active_support/core_ext/object/with_options.rb
@@ -92,10 +92,10 @@ class Object
   def with_options(options, &block)
     option_merger = ActiveSupport::OptionMerger.new(self, options)
 
-    if block.nil?
-      option_merger
-    else
+    if block
       block.arity.zero? ? option_merger.instance_eval(&block) : block.call(option_merger)
+    else
+      option_merger
     end
   end
 end