Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix stack level too deep when model does not have attributes method.
Without that patch when using ActiveModel::AttributeMethods in a class that does not respond to `attributes` method, stack level too deep error will be raised on non existing method. While documentation is clear that you need to define `attributes` method in order to use AttributeMethods module, `stack level too deep` is rather obscure and hard to debug, therefore we should try to not break `method_missing` if someone forgets about defining `attributes`.
- Loading branch information
b164e81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't You forget the 't'? In
ModelWithouAttributesMethod
...b164e81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ECOMMON
b164e81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just to troll you
I will push a fix to other broken tests in a few minutes and will fix it as well there.
b164e81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and we definitely should request @github for a emoji.
b164e81
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FFFFFFFUUUUUUUUUU, it seems I can't even add a comment properly :P