Skip to content

Commit

Permalink
Remove cache_format_version from new_framework_defaults file
Browse files Browse the repository at this point in the history
As noted in #45293 this setting doesn't work in initializers, nor in `config/application.rb`, in Rails 7. Anyone who has set `Rails.application.config.active_support.cache_format_version = 7.0` is still using the Rails 6.1 coder.

This PR removes it from new framework defaults, so that users don't set it and expect it to do something.

In a future PR I will be making this the new default in 7.1 as discussed [here](#45293 (comment)).
  • Loading branch information
ghiculescu committed Jun 8, 2022
1 parent d15a694 commit b19cff1
Showing 1 changed file with 11 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,6 @@
# implementation.
# Rails.application.config.active_support.remove_deprecated_time_with_zone_name = true

# Change the format of the cache entry.
# Changing this default means that all new cache entries added to the cache
# will have a different format that is not supported by Rails 6.1 applications.
# Only change this value after your application is fully deployed to Rails 7.0
# and you have no plans to rollback.
# Rails.application.config.active_support.cache_format_version = 7.0

# Calls `Rails.application.executor.wrap` around test cases.
# This makes test cases behave closer to an actual request or job.
# Several features that are normally disabled in test, such as Active Record query cache
Expand Down Expand Up @@ -104,6 +97,17 @@
# "Referrer-Policy" => "strict-origin-when-cross-origin"
# }


# ** Please read carefully, this must be configured in config/application.rb **
# Change the format of the cache entry.
# Changing this default means that all new cache entries added to the cache
# will have a different format that is not supported by Rails 6.1 applications.
# Only change this value after your application is fully deployed to Rails 7.0
# and you have no plans to rollback.
# When you're ready to change format, add this to `config/application.rb` (NOT this file):
# config.active_support.cache_format_version = 7.0


# Cookie serializer: 2 options
#
# If you're upgrading and haven't set `cookies_serializer` previously, your cookie serializer
Expand Down

0 comments on commit b19cff1

Please sign in to comment.