Merge pull request #13745 from nextgearcapital/master

set encoding for pipe to binary mode
rails · Jan 19, 2014 · b1b21f9 · b1b21f9
2 parents 935d235 + 0e9144d
commit b1b21f9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/activerecord/test/cases/base_test.rb b/activerecord/test/cases/base_test.rb
@@ -1380,6 +1380,8 @@ def test_marshal_between_processes
       })
 
       rd, wr = IO.pipe
+      rd.binmode
+      wr.binmode
 
       ActiveRecord::Base.connection_handler.clear_all_connections!
 

diff --git a/activerecord/test/cases/connection_management_test.rb b/activerecord/test/cases/connection_management_test.rb
@@ -31,6 +31,8 @@ def test_connection_pool_per_pid
           object_id = ActiveRecord::Base.connection.object_id
 
           rd, wr = IO.pipe
+          rd.binmode
+          wr.binmode
 
           pid = fork {
             rd.close

diff --git a/activesupport/lib/active_support/testing/isolation.rb b/activesupport/lib/active_support/testing/isolation.rb
@@ -37,6 +37,8 @@ def run
       module Forking
         def run_in_isolation(&blk)
           read, write = IO.pipe
+          read.binmode
+          write.binmode
 
           pid = fork do
             read.close