Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove complexity from the custom query logs
We only have two specific implementations, so we don't need to create generic formatter implementations for this feature.
- Loading branch information
1 parent
cc8658a
commit b48abc0
Showing
2 changed files
with
25 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b48abc0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate you taking the time to clean this up!
I think I went a little overboard with the factory pattern and "composition over inheritance", which is unnecessary with only 2 formatters. Thanks for simplifying this.
I'm looking forward to seeing how sqlcommenter is adopted in 7.1.x. Hopefully we can remove the legacy formatter in the next release, and simplify this code even further :)