-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -684,7 +684,7 @@ class GoodnessValidator | |
end | ||
end | ||
|
||
# … | ||
# ... | ||
end | ||
``` | ||
|
||
|
3 comments
on commit b77f25c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have mixed feelings about this one. The quotes around attributes have definitely improved; they must always be the straight variant.
But the em-dashes and apostrophes looked fine to me and typographically correct. Is this in the style guide, or is it an encoding problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all started with some encoding problems and did a generic cleanup of anything that was not necessary.
I agree that em-dashes are typographically correct for comments, but they seemed too narrow to me, didn't seem em. And some had spaces around, some others didn't. Indeed, I do not know if our formatter supports three hyphens in a row to mean an em-dash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that it's a definite improvement overall.
I will think about a PR to improve the results further in post-processing.
uses's -> user's