refactor ActiveSupport::TestCase.test_order method with memoization

rails · May 4, 2015 · bf501e7 · bf501e7
1 parent 21c74bd
commit bf501e7
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/activesupport/lib/active_support/test_case.rb b/activesupport/lib/active_support/test_case.rb
@@ -36,14 +36,7 @@ def test_order=(new_order)
       # Possible values are +:random+, +:parallel+, +:alpha+, +:sorted+.
       # Defaults to +:random+.
       def test_order
-        test_order = ActiveSupport.test_order
-
-        if test_order.nil?
-          test_order = :random
-          self.test_order = test_order
-        end
-
-        test_order
+        ActiveSupport.test_order ||= :random
       end
     end