Skip to content

Commit

Permalink
Merge pull request #48860 from akhilgkrishnan/removed-the-typo
Browse files Browse the repository at this point in the history
Fixed few typos in tests and guide
  • Loading branch information
rafaelfranca committed Aug 1, 2023
2 parents 4c9a990 + f171101 commit c0dd179
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion activerecord/test/cases/associations/eager_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ def test_loading_with_no_associations
# Regression test for 21c75e5
def test_nested_loading_does_not_raise_exception_when_association_does_not_exist
assert_nothing_raised do
Post.all.merge!(includes: { author: :author_addresss }).find(posts(:authorless).id)
Post.all.merge!(includes: { author: :non_existing_association }).find(posts(:authorless).id)
end
end

Expand Down
4 changes: 2 additions & 2 deletions activerecord/test/cases/delegated_type_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,15 +95,15 @@ class DelegatedTypeTest < ActiveRecord::TestCase
test "touch account" do
previous_account_updated_at = @entry_with_message.account.updated_at
previous_entry_updated_at = @entry_with_message.updated_at
previous_messsage_updated_at = @entry_with_message.entryable.updated_at
previous_message_updated_at = @entry_with_message.entryable.updated_at

travel 5.seconds do
Recipient.create! message: @entry_with_message.entryable, email_address: "test@test.com"
end

assert_not_equal @entry_with_message.reload.account.updated_at, previous_account_updated_at
assert_not_equal @entry_with_message.reload.updated_at, previous_entry_updated_at
assert_not_equal @entry_with_message.reload.entryable.updated_at, previous_messsage_updated_at
assert_not_equal @entry_with_message.reload.entryable.updated_at, previous_message_updated_at
end

test "builder method" do
Expand Down
2 changes: 1 addition & 1 deletion guides/source/4_1_release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ for detailed changes.

* Calling `update_attributes` will now throw an `ArgumentError` whenever it
gets a `nil` argument. More specifically, it will throw an error if the
argument that it gets passed does not respond to to
argument that it gets passed does not respond to
`stringify_keys`. ([Pull Request](https://github.com/rails/rails/pull/9860))

* `CollectionAssociation#first`/`#last` (e.g. `has_many`) use a `LIMIT`ed
Expand Down

0 comments on commit c0dd179

Please sign in to comment.