-
Notifications
You must be signed in to change notification settings - Fork 21.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #19456 from greysteil/index-exists-behaviour
Ignore index name in `index_exists?` when not passed a name to check for
- Loading branch information
Showing
7 changed files
with
126 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
require 'cases/helper' | ||
|
||
module ActiveRecord | ||
class Migration | ||
class CompatibilityTest < ActiveRecord::TestCase | ||
attr_reader :connection | ||
self.use_transactional_tests = false | ||
|
||
def setup | ||
super | ||
@connection = ActiveRecord::Base.connection | ||
@verbose_was = ActiveRecord::Migration.verbose | ||
ActiveRecord::Migration.verbose = false | ||
|
||
connection.create_table :testings do |t| | ||
t.column :foo, :string, :limit => 100 | ||
t.column :bar, :string, :limit => 100 | ||
end | ||
end | ||
|
||
teardown do | ||
connection.drop_table :testings rescue nil | ||
ActiveRecord::Migration.verbose = @verbose_was | ||
end | ||
|
||
def test_migration_doesnt_remove_named_index | ||
connection.add_index :testings, :foo, :name => "custom_index_name" | ||
|
||
migration = Class.new(ActiveRecord::Migration[4.2]) { | ||
def version; 101 end | ||
def migrate(x) | ||
remove_index :testings, :foo | ||
end | ||
}.new | ||
|
||
assert connection.index_exists?(:testings, :foo, name: "custom_index_name") | ||
assert_raise(StandardError) { ActiveRecord::Migrator.new(:up, [migration]).migrate } | ||
assert connection.index_exists?(:testings, :foo, name: "custom_index_name") | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters