Avoid extra Array allocation

rails · Jan 15, 2020 · c900cdf · c900cdf
1 parent ac206e6
commit c900cdf
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/activerecord/lib/active_record/associations/preloader/association.rb b/activerecord/lib/active_record/associations/preloader/association.rb
@@ -48,18 +48,18 @@ def load_records
             raw_records = owner_keys.empty? ? [] : records_for(owner_keys)
 
             @preloaded_records = raw_records.select do |record|
-              assignments = []
+              assignments = false
 
               owners_by_key[convert_key(record[association_key_name])].each do |owner|
                 entries = (@records_by_owner[owner] ||= [])
 
                 if reflection.collection? || entries.empty?
                   entries << record
-                  assignments << record
+                  assignments = true
                 end
               end
 
-              !assignments.empty?
+              assignments
             end
           end