Skip to content

Commit

Permalink
Remove deprecated methods initialize_schema_migrations_table and `i…
Browse files Browse the repository at this point in the history
…nitialize_internal_metadata_table`
  • Loading branch information
rafaelfranca committed Oct 23, 2017
1 parent 63cf158 commit c9660b5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 15 deletions.
4 changes: 4 additions & 0 deletions activerecord/CHANGELOG.md
@@ -1,3 +1,7 @@
* Remove deprecated methods `initialize_schema_migrations_table` and `initialize_internal_metadata_table`.

*Rafael Mendonça França*

* Raises when calling `lock!` in a dirty record.

*Rafael Mendonça França*
Expand Down
Expand Up @@ -1015,16 +1015,6 @@ def dump_schema_information #:nodoc:
insert_versions_sql(versions) if versions.any?
end

def initialize_schema_migrations_table # :nodoc:
ActiveRecord::SchemaMigration.create_table
end
deprecate :initialize_schema_migrations_table

def initialize_internal_metadata_table # :nodoc:
ActiveRecord::InternalMetadata.create_table
end
deprecate :initialize_internal_metadata_table

def internal_string_options_for_primary_key # :nodoc:
{ primary_key: true }
end
Expand Down
5 changes: 0 additions & 5 deletions activerecord/test/cases/migration_test.rb
Expand Up @@ -1107,11 +1107,6 @@ def test_unknown_migration_version_should_raise_an_argument_error
assert_raise(ArgumentError) { ActiveRecord::Migration[1.0] }
end

def test_deprecate_initialize_internal_tables
assert_deprecated { ActiveRecord::Base.connection.initialize_schema_migrations_table }
assert_deprecated { ActiveRecord::Base.connection.initialize_internal_metadata_table }
end

def test_deprecate_supports_migrations
assert_deprecated { ActiveRecord::Base.connection.supports_migrations? }
end
Expand Down

0 comments on commit c9660b5

Please sign in to comment.