Skip to content

Commit

Permalink
Merge branch 'migration-timestamp-fix'
Browse files Browse the repository at this point in the history
Closes #28707.
  • Loading branch information
gmcgibbon committed May 10, 2019
2 parents 36d145c + 93d2090 commit e84ee74
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 0 deletions.
2 changes: 2 additions & 0 deletions activerecord/CHANGELOG.md
@@ -1,3 +1,5 @@
* Allow generated create_table migrations to include or skip timestamps

*Michael Duchemin*

Please check [6-0-stable](https://github.com/rails/rails/blob/6-0-stable/activerecord/CHANGELOG.md) for previous changes.
Expand Up @@ -7,6 +7,7 @@ module Generators # :nodoc:
class MigrationGenerator < Base # :nodoc:
argument :attributes, type: :array, default: [], banner: "field[:type][:index] field[:type][:index]"

class_option :timestamps, type: :boolean
class_option :primary_key_type, type: :string, desc: "The type for primary key"
class_option :database, type: :string, aliases: %i(--db), desc: "The database for your migration. By default, the current environment's primary database is used."

Expand Down
2 changes: 2 additions & 0 deletions guides/source/active_record_migrations.md
Expand Up @@ -225,6 +225,8 @@ class CreateProducts < ActiveRecord::Migration[5.0]
create_table :products do |t|
t.string :name
t.string :part_number

t.timestamps
end
end
end
Expand Down
15 changes: 15 additions & 0 deletions railties/test/generators/migration_generator_test.rb
Expand Up @@ -270,6 +270,21 @@ def test_create_table_migration
end
end

def test_create_table_migration_with_timestamps
run_generator ["create_books", "title:string", "content:text"]
assert_migration "db/migrate/create_books.rb", /t.timestamps/
end

def test_create_table_timestamps_are_skipped
run_generator ["create_books", "title:string", "content:text", "--no-timestamps"]

assert_migration "db/migrate/create_books.rb" do |m|
assert_method :change, m do |change|
assert_no_match(/t.timestamps/, change)
end
end
end

def test_add_uuid_to_create_table_migration
run_generator ["create_books", "--primary_key_type=uuid"]
assert_migration "db/migrate/create_books.rb" do |content|
Expand Down

0 comments on commit e84ee74

Please sign in to comment.