Merge pull request #46617 from r7kamura/feature/isolation-level-default

Remove unnecessary isolation_level setting from load_defaults 7.0
rails · Aug 9, 2023 · eb7e42d · eb7e42d
1 parent 2dccb3f
commit eb7e42d
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 7 deletions.
diff --git a/guides/source/configuring.md b/guides/source/configuring.md
@@ -78,7 +78,6 @@ Below are the default values associated with each target version. In cases of co
 - [`config.active_support.disable_to_s_conversion`](#config-active-support-disable-to-s-conversion): `true`
 - [`config.active_support.executor_around_test_case`](#config-active-support-executor-around-test-case): `true`
 - [`config.active_support.hash_digest_class`](#config-active-support-hash-digest-class): `OpenSSL::Digest::SHA256`
-- [`config.active_support.isolation_level`](#config-active-support-isolation-level): `:thread`
 - [`config.active_support.key_generator_hash_digest_class`](#config-active-support-key-generator-hash-digest-class): `OpenSSL::Digest::SHA256`
 - [`config.active_support.remove_deprecated_time_with_zone_name`](#config-active-support-remove-deprecated-time-with-zone-name): `true`
 - [`config.active_support.use_rfc4122_namespaced_uuids`](#config-active-support-use-rfc4122-namespaced-uuids): `true`

diff --git a/railties/lib/rails/application/configuration.rb b/railties/lib/rails/application/configuration.rb
@@ -230,7 +230,6 @@ def load_defaults(target_version)
             active_support.cache_format_version = 7.0
             active_support.use_rfc4122_namespaced_uuids = true
             active_support.executor_around_test_case = true
-            active_support.isolation_level = :thread
             active_support.disable_to_s_conversion = true
           end
 

diff --git a/...rails/generators/rails/app/templates/config/initializers/new_framework_defaults_7_0.rb.tt b/...rails/generators/rails/app/templates/config/initializers/new_framework_defaults_7_0.rb.tt
@@ -40,11 +40,6 @@
 # and asynchronous queries will then be enabled.
 # Rails.application.config.active_support.executor_around_test_case = true
 
-# Define the isolation level of most of Rails internal state.
-# If you use a fiber based server or job processor, you should set it to `:fiber`.
-# Otherwise the default of `:thread` if preferable.
-# Rails.application.config.active_support.isolation_level = :thread
-
 # Set both the `:open_timeout` and `:read_timeout` values for `:smtp` delivery method.
 # Rails.application.config.action_mailer.smtp_timeout = 5