Skip to content
Browse files

transactional migration test-case was broken.

The cleanup commit a85625d broke the test-case.
The schema was no longer modified so there was no
way to check that the rollback actually happened.
  • Loading branch information...
1 parent 09d1fb2 commit f1241ef959a45d1b66e2e9399a3e1b09cf95cc2c @senny senny committed Mar 1, 2013
Showing with 7 additions and 3 deletions.
  1. +7 −3 activerecord/test/cases/migration_test.rb
View
10 activerecord/test/cases/migration_test.rb
@@ -239,9 +239,13 @@ def test_migrator_one_up_with_exception_and_rollback
assert_not Person.column_methods_hash.include?(:last_name)
- migration = Struct.new(:name, :version) {
- def migrate(x); raise 'Something broke'; end
- }.new('zomg', 100)
+ migration = Class.new(ActiveRecord::Migration) {
+ def version; 100 end
+ def migrate(x)
+ add_column "people", "last_name", :string
+ raise 'Something broke'
+ end
+ }.new
migrator = ActiveRecord::Migrator.new(:up, [migration], 100)

0 comments on commit f1241ef

Please sign in to comment.
Something went wrong with that request. Please try again.