Merge pull request #267 from jordansexton/patch-1

Return self from distinct so it's chainable
rails · May 19, 2014 · f6ab8cf · f6ab8cf
2 parents be9963a + acdd8e4
commit f6ab8cf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/lib/arel/select_manager.rb b/lib/arel/select_manager.rb
@@ -148,6 +148,7 @@ def distinct(value = true)
       else
         @ctx.set_quantifier = nil
       end
+      self
     end
 
     def order *expr

diff --git a/test/test_select_manager.rb b/test/test_select_manager.rb
@@ -1073,6 +1073,12 @@ def test_manager_stores_bind_values
         manager.distinct(false)
         manager.ast.cores.last.set_quantifier.must_equal nil
       end
+
+      it "chains" do
+        manager = Arel::SelectManager.new Table.engine
+        manager.distinct.must_equal manager
+        manager.distinct(false).must_equal manager
+      end
     end
   end
 end