Use dup to preserve previous behavior

rails · May 17, 2011 · fb3ea8b · fb3ea8b
1 parent 0a070a2
commit fb3ea8b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/activesupport/lib/active_support/hash_with_indifferent_access.rb b/activesupport/lib/active_support/hash_with_indifferent_access.rb
@@ -11,7 +11,7 @@ def extractable_options?
     end
 
     def with_indifferent_access
-      self
+      dup
     end
 
     def initialize(constructor = {})

diff --git a/activesupport/test/core_ext/hash_ext_test.rb b/activesupport/test/core_ext/hash_ext_test.rb
@@ -971,7 +971,7 @@ def test_should_nil_if_no_default_value_is_supplied
     assert_nil hash_wia.default
   end
 
-  def test_should_return_self_for_with_indifferent_access
+  def test_should_return_dup_for_with_indifferent_access
     hash_wia = HashWithIndifferentAccess.new
     assert_equal hash_wia, hash_wia.with_indifferent_access
   end