Does not fail replacing children when destroy of a child fails.

[arturopie]

When using a has many association with options autosave: true and dependent: :destroy, and destroying a child fails, replacing all the children will not fail. In fact, it will end up merging new children with the children to which destroy failed

Here is an example test:

class Post < ActiveRecord::Base
  has_many :comments, autosave: true, dependent: :destroy

  attr_accessible :comments
end

class Comment < ActiveRecord::Base
  before_destroy :fail

  def fail
    self.errors.add(:base, "Comment can not be deleted")
    return false
  end
end

class AutosaveTest < ActiveSupport::TestCase
  def test_autosave_replace
    post = Post.create! comments: [Comment.create!]
    orig_comments = post.comments.dup

    post.comments = [Comment.create!]

    assert_equal orig_comments, Post.find(post.id).comments
  end
end

Post.find(post.id).comments will end up returning 2 comments, instead of only one.
I'm using rails 3.2.15

[rafaelfranca]

Does this works on Rails 4.0.1? Rails 3.2 is not supported anymore

[arturopie]

I confirm this is an issue in Rails 4.0.1 as well

[brianstorti]

Do you guys think that raising an ActiveRecord::RecordNotDestroyed when I try to replace the children is enough?

[albertopriore]

Do you have any update on this issue?