Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we clean preview_interceptors #14326

Merged
merged 1 commit into from
Mar 8, 2014
Merged

Make sure we clean preview_interceptors #14326

merged 1 commit into from
Mar 8, 2014

Conversation

arthurnn
Copy link
Member

@arthurnn arthurnn commented Mar 8, 2014

backport #14318 to 4-1 .

I am 95% that this fixed the mailer issue on travis.

travis is now failing randomly for another reason:

1) Error:
MemCacheStoreTest#test_deserializes_unloaded_class:
ArgumentError: key cannot be blank

So we should backport this to 4-1-stable. cc @pixeltrix

@arthurnn
Make sure we clean preview_interceptors
3ac2aea 
We should make sure we clean preview_interceptors after each test so they dont leaky to the next test
@robin850
Copy link
Member

robin850 commented Mar 8, 2014

With current master I personally still have this random failure (see this gist). :-(

@spastorino
Copy link
Contributor

Anyway seems 👍 to have this in

spastorino added a commit that referenced this pull request Mar 8, 2014
@spastorino
Merge pull request #14326 from arthurnn/backport_14318
9f559b0 
Make sure we clean preview_interceptors
@spastorino spastorino merged commit 9f559b0 into rails:4-1-stable Mar 8, 2014
@arthurnn arthurnn deleted the backport_14318 branch March 8, 2014 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arthurnn @robin850 @spastorino