Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AC::TemplateAssertions instance variables not resetting. #16234

Merged

Conversation

tgxworld
Copy link
Contributor

Fixes #16119.

@senny
Copy link
Member

senny commented Jul 20, 2014

This is probably related to:

https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/test_case.rb#L16-L19

and

https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/test_case.rb#L59-L61

If so, we should find a common place that can be used from the different call sites.

@tgxworld
Copy link
Contributor Author

Hmm that is strange, I actually move the reset method into AC::TemplateAssertions and thought I pushed the new commit up. Should I merge this pull request with #16027?

@tgxworld
Copy link
Contributor Author

@senny ping in case you missed the above 😄

senny added a commit that referenced this pull request Jul 22, 2014
…tegration_test

Fix AC::TemplateAssertions instance variables not resetting.
@senny senny merged commit 74a157a into rails:master Jul 22, 2014
@senny
Copy link
Member

senny commented Jul 22, 2014

@tgxworld sorry for the delayed response. I merged this one. You can rebase the other one on top and make the necessary extraction. Goal would be to have all the = nil only in one place.

@tgxworld
Copy link
Contributor Author

@senny No worries. I didn't tagged you when I commented so I thought I might not have notified you xD Thank you for reviewing!

@tgxworld
Copy link
Contributor Author

@rubys Is there a way that I can see the code in the controller? Looking at the code in the link above, I can't find anything wrong with it immediately yet. Thanks!

@rubys
Copy link
Contributor

rubys commented Jul 23, 2014

@tgxworld nothing special is required in the controller. See minimal test case.

tgxworld added a commit to tgxworld/rails that referenced this pull request Jul 24, 2014
@tgxworld tgxworld deleted the fix_template_assertion_for_integration_test branch September 3, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActionController::TemplateAssertions does not reset between requests for Integration Tests
3 participants