Set Psych as the YAML engine for Rubinius #16267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| comment = 'Use Psych as the YAML engine, instead of Syck, so serialized ' \ | ||
| 'data can be read safely from different rubies (see http://git.io/uuLVag)' | ||
| GemfileEntry.new('psych', '~> 2.0', comment) |
There was a problem hiding this comment.
Should not we only include psych if the platform is rbx?
There was a problem hiding this comment.
Yes, we do. The return statement at line 318 avoid these lines to be reached if we are on Rubinius. To be honest, I've just followed the example of Spring. :-)
There was a problem hiding this comment.
Yes, but maybe we should add platform: :rbx too.
There was a problem hiding this comment.
I think that would be GemfileEntry.new('psych', '~> 2.0', comment, { platforms: :rbx })
There was a problem hiding this comment.
Ah yes, fair point! Thank you guys ; updated!
Since the rubysl-yaml gem doesn't ship with Psych by default because of its dependency on libyaml, on Rubinius, the default engine is Syck. However, if we want to be able to run the application safely on different rubies, we need to make people using Rubinius rely on Psych. See http://git.io/uuLVag for further information.
rafaelfranca
added a commit
that referenced
this pull request
Jul 23, 2014
Set Psych as the YAML engine for Rubinius
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since the rubysl-yaml gem doesn't ship with Psych by default because of its dependency on libyaml, on Rubinius, the default engine is Syck. However, if we want to be able to run the application safely on different rubies, we need to make people using Rubinius rely on Psych.
See http://git.io/uuLVag for further information.
Have a nice day.