Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when script_name is nil in options for ActionDispatch::Routing::RouteSet::UrlHelper#url_for #17615

Closed
JONBRWN opened this issue Nov 13, 2014 · 0 comments
Closed

Error when script_name is nil in options for ActionDispatch::Routing::RouteSet::UrlHelper#url_for #17615

JONBRWN opened this issue Nov 13, 2014 · 0 comments

Comments

@JONBRWN
Copy link
Contributor

JONBRWN commented Nov 13, 2014

Error:
no implicit conversion of nil into String

756: script_name = original_script_name + script_name

This occurs when script_name is nil in the options hash. Working on pull request with fix.
JONBRWN added a commit to JONBRWN/rails that referenced this issue Nov 14, 2014
@JONBRWN
sets script_name to always be a string.
a54aad6 
see issue: rails#17615

when script_name is nil in the options hash, script_name is set to nil.

options = {script_name: nil}
script_name = options.delete(:script_name) {‘’} # => nil
@JONBRWN JONBRWN mentioned this issue Nov 14, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JONBRWN