Fix mysql's schema.rb dumper so it does not include limit on emulated booleans #19066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… boolean tinyint(1) fields
rafaelfranca
added a commit
that referenced
this pull request
Feb 24, 2015
Fix mysql's schema.rb dumper so it does not include limit on emulated booleans
rafaelfranca
added a commit
that referenced
this pull request
Feb 24, 2015
Fix mysql's schema.rb dumper so it does not include limit on emulated booleans
|
Backported as 36fa6f9 |
pixeltrix
added a commit
to alphagov/e-petitions
that referenced
this pull request
May 5, 2015
Some tweaks were needed to the schema.rb file because of duplicate index names and a issue with a `limit: 1` being added to boolean columns - for further information see rails/rails#19066[1]. [1]: rails/rails#19066
pixeltrix
added a commit
to alphagov/e-petitions
that referenced
this pull request
May 5, 2015
Some tweaks were needed to the schema.rb file because of duplicate index names and a issue with a `limit: 1` being added to boolean columns - for further information see rails/rails#19066[1]. [1]: rails/rails#19066
benlovell
added a commit
to alphagov/whitehall
that referenced
this pull request
Feb 2, 2016
Adds `Classification#content_id` attribute and ensures placeholder content is published upon creation. A bunch of unrelated things were modified in `schema.rb` due to changes in Rails' generation of `boolean` columns. See: rails/rails#19066 [1] [1] rails/rails#19066
benlovell
added a commit
to alphagov/whitehall
that referenced
this pull request
Feb 2, 2016
Adds `Classification#content_id` attribute and ensures placeholder content is published upon creation. A bunch of unrelated things were modified in `schema.rb` due to changes in Rails' generation of `boolean` columns. See: rails/rails#19066 [1] [1] rails/rails#19066
benlovell
added a commit
to alphagov/whitehall
that referenced
this pull request
Feb 2, 2016
Since a recent Rails upgrade (`> 4.2.2`) included rails/rails#19066 [1], and running a migration in an ongoing PR produced these incidental changes, we decided offline to highlight them in a separate commit and subsequent PR. [1] rails/rails#19066
benlovell
added a commit
to alphagov/whitehall
that referenced
this pull request
Feb 2, 2016
Since a recent Rails upgrade (`> 4.2.2`) included rails/rails#19066 [1], and running a migration in an ongoing PR produced these incidental changes, we decided offline to highlight them in a separate commit and subsequent PR. [1] rails/rails#19066
benlovell
added a commit
to alphagov/whitehall
that referenced
this pull request
Feb 2, 2016
Adds `Classification#content_id` attribute and ensures placeholder content is published upon creation. A bunch of unrelated things were modified in `schema.rb` due to changes in Rails' generation of `boolean` columns. See: rails/rails#19066 [1] [1] rails/rails#19066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #19065