-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci skip] Update documentation for Range#to_formatted_s #19128
Conversation
I don't think we should tell people to replace and break the |
@kaspth yes, you're right, thanks! 鉂わ笍 |
f99e45c
to
76f7fd3
Compare
@kaspth fixed this |
d63eb23
to
5b8ed45
Compare
I'd love it if we could make the documentation here more consistent with Date's rails/activesupport/lib/active_support/core_ext/date/conversions.rb Lines 28 to 51 in afc98ea
|
5b8ed45
to
0d8c983
Compare
@kaspth fixed this too 馃槂 |
0d8c983
to
3f2ab06
Compare
# == Adding your own range formats to to_formatted_s | ||
# You can add your own formats to the Range::RANGE_FORMATS hash. | ||
# Use the format name as the hash key and either a Proc instance | ||
# that takes a start and stop arguments as the value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove a: that takes a start and stop arguments as the value.
3f2ab06
to
032d279
Compare
@kaspth fixed all. Thanks for review! 馃挌 馃挍 鉂わ笍 |
No problem, 馃憤. The documentation here is way better because of your work 鉂わ笍 |
[ci skip] Update documentation for Range#to_formatted_s
Holy crap! You got the 50000th commit to Rails 馃槈 |
WOW! 馃帀 thanks! 馃専 |
馃帀 |
Added information about default
:db
format and added information about custom formats 馃帀