Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC::Parameters no longer being a Hash has broken find_or_initialize_by #20990

Closed
twalpole opened this issue Jul 23, 2015 · 7 comments
Closed
Assignees
Milestone

Comments

@twalpole
Copy link
Contributor

Strong parameters can no longer be passed to find_or_initialize_by since it expects a Hash to be passed through to the find_by cal which errors with "Cannot visit ActionController::Parameters.

@rafaelfranca rafaelfranca added this to the 5.0.0 milestone Jul 23, 2015
@mrageh
Copy link
Contributor

mrageh commented Jul 23, 2015

@twalpole I am not sure but this commit may be relevant to this issue 68af636

@jonatack
Copy link
Contributor

And #20945 / #20922.

@jaredbeck
Copy link
Contributor

In case anyone is curious (I was) about why Parameters no longer inherits Hash, it's explained in this commit: 14a3bd5

@sikachu
Copy link
Member

sikachu commented Dec 13, 2015

@sgrif would you mind taking a look at this? Your commit was referred to in the first comment.

@sgrif
Copy link
Contributor

sgrif commented Dec 13, 2015

Yup, I'm on vacation but I'll look when I get back

On Sat, Dec 12, 2015, 8:25 PM Prem Sichanugrist notifications@github.com
wrote:

@sgrif https://github.com/sgrif would you mind taking a look at this?
Your commit was referred to in the first comment.


Reply to this email directly or view it on GitHub
#20990 (comment).

@twalpole
Copy link
Contributor Author

This was fixed by PR #21000

@sgrif
Copy link
Contributor

sgrif commented Dec 16, 2015

thanks

@rafaelfranca rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants