Revise #23717 (Add "Rendering ..." message) using proper ActiveSupport::LogSubscriber#start #23915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that we have started to render something, at the very beginning. This helps to easily identify queries from controller vs views Fixes rails#23710
We don't need to instrument another event as `ActiveSupport::LogSubscriber` already tracks when the instrumentation starts. Close rails#23717
rafaelfranca
added a commit
that referenced
this pull request
Feb 26, 2016
Revise #23717 (Add "Rendering ..." message) using proper ActiveSupport::LogSubscriber#start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I revise #23717 by defining
#startmethod instead of instrument another event.r? @rafaelfranca